Stationary

Post by **jordansparks** » Sun Jul 29, 2007 8:18 am

I've finally had a moment to review the stationary feature. I have the following comments:
1. The word processor path should be eliminated. Windows can use the extension .doc to figure out which program to use to launch it.
2. You can't use @"\" to join paths. That won't work on Linux.
3. Please don't leave extra lines inside methods.
4. Please leave a single line between methods. There are many places where there was no blank line between methods.
5. There were some indentation errors.
6. Delete, OK, Cancel, and Close events need to all come after any other methods. Please do not put extra methods after them.
7. It is confusing that there is both a stationary jpg and a stationary doc. The confusion can be resolved by slightly changing the explanations.
8. I changed the help tool tip in FormMisc to stay up longer. I would have it stay up permanently if I could figure out how. There's a lot of info to digest inside those tool tips. I'm trying to copy that data to the online manual.
9. Please refer to prefs using PrefB.Get.. instead of directly referencing the hashtable. The hashtable is going to be private asap, and continuing to reference it makes more work for us.
10. The DocPath pref should never be accessed directly. Some users have multiple paths there, or no path at all.

I will be fixing the above issues in 5.0 since you don't have access to them. I'll leave it to you to bring the changes forward to 5.1. Look for my commit in an hour or two. I'm actually not sure if I will have time to test my changes. I plan to probably commit first and test later.

drtech · Post by **drtech** » Sun Jul 29, 2007 12:41 pm

ok....looking over it now

drtech · Post by **drtech** » Sun Jul 29, 2007 1:22 pm

I see all the changes and I think got the all copied over to v5.1.

I see the problems above and what I should do differently in the future. I will also try follow the coding rules you mentioned.

What do you think about moving the CommLog button back off from the formCommunications to directly on the Account again? Using it the last few weeks seems like that is the most common button to use and it doubles your clicks to open the separate window.

Post by **jordansparks** » Sun Jul 29, 2007 1:28 pm

That sounds fine. Also, I assume you are using the stationary feature, so you would notice if it had any bugs? I've never tested it.

drtech · Post by **drtech** » Sun Jul 29, 2007 1:32 pm

yes, it has worked fine so far, & I am sure the new code will too...should be able to test it by tomorrow in the real world.

drtech · Post by **drtech** » Sun Jul 29, 2007 5:36 pm

Doesn't seem like the word processor is launching now without the path specified. I know it should launch the associated file, but it doesn't seem to work.

Post by **jordansparks** » Sun Jul 29, 2007 6:21 pm

It worked for me just now in 5.0. Launched Open Office. Check your file type associations. From any folder, Tool | Folder Options | File Types.