GetAppointmentsForPeriod() question

[mopensoft]

I was a bit confuse with this function as it always give me empty list result:

Code: Select all

   public static List<Appointment> GetAppointmentsForPeriod(DateTime start,DateTime end) {
			if(RemotingClient.RemotingRole==RemotingRole.ClientWeb) {
				return Meth.GetObject<List<Appointment>>(MethodBase.GetCurrentMethod(),start,end);
			}
			string command="SELECT * FROM appointment WHERE ";
			command+="AptDateTime >= "+POut.DateT(start.Date);//to check to see if an appointment scheduled beforehand overlaps this time segment
			command+="AND AptDateTime <= "+POut.DateT(end);
			List<Appointment> retVal = Crud.AppointmentCrud.TableToList(Db.GetTable(command));
			for(int i=retVal.Count-1;i>=0;i--) {
				if(retVal[i].AptDateTime.AddMinutes(retVal[i].Pattern.Length*PrefC.GetInt(PrefName.AppointmentTimeIncrement))>start) {
					retVal.RemoveAt(i);
				}
			}
			return retVal;
		}

I think the checking condition may be the problem as it's always true. It should be "end" rather than "start", shouldn't it?

Cheers
M

[jsalmon]

I agree this method does not look complete. I see that it is not referenced anywhere. I looked at the history of the file and noticed when it was written it never got used. This leads me further to believe that it is not a completed method. You might try the method GetForPeriodList(). That will essentially give you the same results you would get from GetAppointmentsForPeriod(), the main difference being that unscheduled and planned appointments are excluded.

[mopensoft]

I rewrote the function in my plugin so it's ok now. Will try GetAppointmentsForPeriod(). Thanks. Minh