Stationary
Posted: Sun Jul 29, 2007 8:18 am
I've finally had a moment to review the stationary feature. I have the following comments:
1. The word processor path should be eliminated. Windows can use the extension .doc to figure out which program to use to launch it.
2. You can't use @"\" to join paths. That won't work on Linux.
3. Please don't leave extra lines inside methods.
4. Please leave a single line between methods. There are many places where there was no blank line between methods.
5. There were some indentation errors.
6. Delete, OK, Cancel, and Close events need to all come after any other methods. Please do not put extra methods after them.
7. It is confusing that there is both a stationary jpg and a stationary doc. The confusion can be resolved by slightly changing the explanations.
8. I changed the help tool tip in FormMisc to stay up longer. I would have it stay up permanently if I could figure out how. There's a lot of info to digest inside those tool tips. I'm trying to copy that data to the online manual.
9. Please refer to prefs using PrefB.Get.. instead of directly referencing the hashtable. The hashtable is going to be private asap, and continuing to reference it makes more work for us.
10. The DocPath pref should never be accessed directly. Some users have multiple paths there, or no path at all.
I will be fixing the above issues in 5.0 since you don't have access to them. I'll leave it to you to bring the changes forward to 5.1. Look for my commit in an hour or two. I'm actually not sure if I will have time to test my changes. I plan to probably commit first and test later.
1. The word processor path should be eliminated. Windows can use the extension .doc to figure out which program to use to launch it.
2. You can't use @"\" to join paths. That won't work on Linux.
3. Please don't leave extra lines inside methods.
4. Please leave a single line between methods. There are many places where there was no blank line between methods.
5. There were some indentation errors.
6. Delete, OK, Cancel, and Close events need to all come after any other methods. Please do not put extra methods after them.
7. It is confusing that there is both a stationary jpg and a stationary doc. The confusion can be resolved by slightly changing the explanations.
8. I changed the help tool tip in FormMisc to stay up longer. I would have it stay up permanently if I could figure out how. There's a lot of info to digest inside those tool tips. I'm trying to copy that data to the online manual.
9. Please refer to prefs using PrefB.Get.. instead of directly referencing the hashtable. The hashtable is going to be private asap, and continuing to reference it makes more work for us.
10. The DocPath pref should never be accessed directly. Some users have multiple paths there, or no path at all.
I will be fixing the above issues in 5.0 since you don't have access to them. I'll leave it to you to bring the changes forward to 5.1. Look for my commit in an hour or two. I'm actually not sure if I will have time to test my changes. I plan to probably commit first and test later.